Skip to content

Commit

Permalink
V4L/DVB: Don't access input_dev->private directly
Browse files Browse the repository at this point in the history
Drivers should use input_{get|set}_drvdata() instead of accessing
input_dev->provate directly, but since these drivers do not actually
use the data stored there we can simply remove the assignments.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Dmitry Torokhov committed Jan 21, 2008
1 parent 4615e33 commit a512a8c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions drivers/media/video/usbvideo/konicawc.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,6 @@ static void konicawc_register_input(struct konicawc *cam, struct usb_device *dev
input_dev->evbit[0] = BIT_MASK(EV_KEY);
input_dev->keybit[BIT_WORD(BTN_0)] = BIT_MASK(BTN_0);

input_dev->private = cam;

error = input_register_device(cam->input);
if (error) {
warn("Failed to register camera's input device, err: %d\n",
Expand Down
2 changes: 0 additions & 2 deletions drivers/media/video/usbvideo/quickcam_messenger.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ static void qcm_register_input(struct qcm *cam, struct usb_device *dev)
input_dev->evbit[0] = BIT_MASK(EV_KEY);
input_dev->keybit[BIT_WORD(BTN_0)] = BIT_MASK(BTN_0);

input_dev->private = cam;

error = input_register_device(cam->input);
if (error) {
warn("Failed to register camera's input device, err: %d\n",
Expand Down

0 comments on commit a512a8c

Please sign in to comment.