Skip to content

Commit

Permalink
[PATCH] SubmitChecklist update
Browse files Browse the repository at this point in the history
Sing the praises of `gcc -W'.  Would have prevented that blockdev direct-IO
bug.

Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andrew Morton authored and Linus Torvalds committed Jan 23, 2007
1 parent 790816d commit a517b9f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Documentation/SubmitChecklist
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,7 @@ kernel patches.

If the new code is substantial, addition of subsystem-specific fault
injection might be appropriate.

22: Newly-added code has been compiled with `gcc -W'. This will generate
lots of noise, but is good for finding bugs like "warning: comparison
between signed and unsigned".

0 comments on commit a517b9f

Please sign in to comment.