Skip to content

Commit

Permalink
toshiba_acpi: Support SPFC as an HCI method
Browse files Browse the repository at this point in the history
Some Toshiba models, notably those with the TOS1900 device, use
the SPFC method for HCI calls instead of GHCI. Test for this method
if GHCI isn't found, and if it exists use it for all HCI calls.

Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
  • Loading branch information
Seth Forshee authored and Matthew Garrett committed Oct 24, 2011
1 parent 6e02cc7 commit a540d6b
Showing 1 changed file with 22 additions and 6 deletions.
28 changes: 22 additions & 6 deletions drivers/platform/x86/toshiba_acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -892,11 +892,26 @@ static int toshiba_acpi_remove(struct acpi_device *acpi_dev, int type)
return 0;
}

static const char * __devinit find_hci_method(acpi_handle handle)
{
acpi_status status;
acpi_handle hci_handle;

status = acpi_get_handle(handle, "GHCI", &hci_handle);
if (ACPI_SUCCESS(status))
return "GHCI";

status = acpi_get_handle(handle, "SPFC", &hci_handle);
if (ACPI_SUCCESS(status))
return "SPFC";

return NULL;
}

static int __devinit toshiba_acpi_add(struct acpi_device *acpi_dev)
{
struct toshiba_acpi_dev *dev;
acpi_status status;
acpi_handle handle;
const char *hci_method;
u32 hci_result;
bool bt_present;
int ret = 0;
Expand All @@ -905,16 +920,17 @@ static int __devinit toshiba_acpi_add(struct acpi_device *acpi_dev)
pr_info("Toshiba Laptop ACPI Extras version %s\n",
TOSHIBA_ACPI_VERSION);

/* simple device detection: look for HCI method */
status = acpi_get_handle(acpi_dev->handle, "GHCI", &handle);
if (ACPI_FAILURE(status))
hci_method = find_hci_method(acpi_dev->handle);
if (!hci_method) {
pr_err("HCI interface not found\n");
return -ENODEV;
}

dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (!dev)
return -ENOMEM;
dev->acpi_dev = acpi_dev;
dev->method_hci = "GHCI";
dev->method_hci = hci_method;
acpi_dev->driver_data = dev;

if (toshiba_acpi_setup_keyboard(dev))
Expand Down

0 comments on commit a540d6b

Please sign in to comment.