Skip to content

Commit

Permalink
[PATCH] I2C: #include <linux/config.h> cleanup
Browse files Browse the repository at this point in the history
Hi Alexey,

> Files that don't use CONFIG_* stuff shouldn't include config.h
> Files that use CONFIG_* stuff should include config.h
>
> It's that simple. ;-)

I agree. This won't change anything though, as all drivers include
either device.h or module.h, which in turn include config.h. But you are
still correct, so I approve your patch.

For completeness, I would propose the following on top of your own
patch:

i2c bus drivers do not need to define DEBUG themselves, as the Kconfig
system takes care of it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jean Delvare authored and Greg Kroah-Hartman committed Jun 22, 2005
1 parent f0bb60e commit a551ef7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions drivers/i2c/busses/i2c-ixp2000.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@
* 'enabled' to drive the GPIOs.
*/

#include <linux/config.h>
#ifdef CONFIG_I2C_DEBUG_BUS
#define DEBUG 1
#endif

#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/device.h>
Expand Down
5 changes: 0 additions & 5 deletions drivers/i2c/busses/i2c-ixp4xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@
* that is passed as the platform_data to this driver.
*/

#include <linux/config.h>
#ifdef CONFIG_I2C_DEBUG_BUS
#define DEBUG 1
#endif

#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/device.h>
Expand Down

0 comments on commit a551ef7

Please sign in to comment.