Skip to content

Commit

Permalink
blkcg: change a spin_lock() to spin_lock_irq()
Browse files Browse the repository at this point in the history
Smatch complains that we re-enable IRQs twice.  It looks like we forgot
to disable them here on the spin_trylock() failure path.  This was added
in 9f13ef6 "blkcg: use double locking instead of RCU for blkg
synchronization".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>`
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Dan Carpenter authored and Jens Axboe committed Mar 29, 2012
1 parent eb7d8c0 commit a556793
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion block/blk-cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -1601,7 +1601,7 @@ static int blkiocg_pre_destroy(struct cgroup_subsys *subsys,
} else {
spin_unlock_irq(&blkcg->lock);
cpu_relax();
spin_lock(&blkcg->lock);
spin_lock_irq(&blkcg->lock);
}
}

Expand Down

0 comments on commit a556793

Please sign in to comment.