Skip to content

Commit

Permalink
iwlwifi: LED initialize before registering
Browse files Browse the repository at this point in the history
This patch initialize all fields in led before registering it
This fixes oops on initialization

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Tomas Winkler authored and John W. Linville committed Apr 1, 2008
1 parent c4f5523 commit a571ea4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/wireless/iwlwifi/iwl-led.c
Original file line number Diff line number Diff line change
Expand Up @@ -238,18 +238,20 @@ static int iwl_leds_register_led(struct iwl_priv *priv,
led->led_dev.brightness_set = iwl4965_led_brightness_set;
led->led_dev.default_trigger = trigger;

led->priv = priv;
led->type = type;

ret = led_classdev_register(device, &led->led_dev);
if (ret) {
IWL_ERROR("Error: failed to register led handler.\n");
return ret;
}

led->priv = priv;
led->type = type;
led->registered = 1;

if (set_led && led->led_on)
led->led_on(priv, IWL_LED_LINK);

return 0;
}

Expand Down

0 comments on commit a571ea4

Please sign in to comment.