Skip to content

Commit

Permalink
drm/i915: Explain why we need to write DPLL twice
Browse files Browse the repository at this point in the history
... it's because setting the Pixel Multiply bits only takes effect once
the PLL is enabled and stable.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Chris Wilson committed Dec 5, 2010
1 parent 17fe698 commit a589b9f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -4089,13 +4089,13 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
}
I915_WRITE(DPLL_MD(pipe), temp);
} else {
/* write it again -- the BIOS does, after all */
/* The pixel multiplier can only be updated once the
* DPLL is enabled and the clocks are stable.
*
* So write it again.
*/
I915_WRITE(dpll_reg, dpll);
}

/* Wait for the clocks to stabilize. */
POSTING_READ(dpll_reg);
udelay(150);
}

intel_crtc->lowfreq_avail = false;
Expand Down

0 comments on commit a589b9f

Please sign in to comment.