Skip to content

Commit

Permalink
stacktrace: print_stack_trace() cleanup
Browse files Browse the repository at this point in the history
- shorter code and better atomicity with regards to printk().

(It's been tested with the backtrace self-test code on i386 and x86_64.)

Cc: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Vegard Nossum authored and Ingo Molnar committed Jun 13, 2008
1 parent 886dd58 commit a5a242d
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions kernel/stacktrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,14 @@

void print_stack_trace(struct stack_trace *trace, int spaces)
{
int i, j;
int i;

if (WARN_ON(!trace->entries))
return;

for (i = 0; i < trace->nr_entries; i++) {
unsigned long ip = trace->entries[i];

for (j = 0; j < spaces + 1; j++)
printk(" ");
print_ip_sym(ip);
printk("%*c", 1 + spaces, ' ');
print_ip_sym(trace->entries[i]);
}
}

0 comments on commit a5a242d

Please sign in to comment.