Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 8226
b: refs/heads/master
c: 5251bff
h: refs/heads/master
v: v3
  • Loading branch information
Daniel Burcaw authored and Linus Torvalds committed Sep 9, 2005
1 parent f630aa6 commit a5de957
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 10 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: c5eb5c1ea919f3f717236c5d0892f9c37f19de37
refs/heads/master: 5251bffc9b4ca699993c79166adf02faf1bbc043
29 changes: 20 additions & 9 deletions trunk/drivers/video/aty/radeon_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -2312,19 +2312,27 @@ static int radeonfb_pci_register (struct pci_dev *pdev,
rinfo->mmio_base_phys = pci_resource_start (pdev, 2);

/* request the mem regions */
ret = pci_request_regions(pdev, "radeonfb");
ret = pci_request_region(pdev, 0, "radeonfb framebuffer");
if (ret < 0) {
printk( KERN_ERR "radeonfb (%s): cannot reserve PCI regions."
" Someone already got them?\n", pci_name(rinfo->pdev));
printk( KERN_ERR "radeonfb (%s): cannot request region 0.\n",
pci_name(rinfo->pdev));
goto err_release_fb;
}

ret = pci_request_region(pdev, 2, "radeonfb mmio");
if (ret < 0) {
printk( KERN_ERR "radeonfb (%s): cannot request region 2.\n",
pci_name(rinfo->pdev));
goto err_release_pci0;
}

/* map the regions */
rinfo->mmio_base = ioremap(rinfo->mmio_base_phys, RADEON_REGSIZE);
if (!rinfo->mmio_base) {
printk(KERN_ERR "radeonfb (%s): cannot map MMIO\n", pci_name(rinfo->pdev));
printk(KERN_ERR "radeonfb (%s): cannot map MMIO\n",
pci_name(rinfo->pdev));
ret = -EIO;
goto err_release_pci;
goto err_release_pci2;
}

rinfo->fb_local_base = INREG(MC_FB_LOCATION) << 16;
Expand Down Expand Up @@ -2499,10 +2507,12 @@ static int radeonfb_pci_register (struct pci_dev *pdev,
if (rinfo->bios_seg)
radeon_unmap_ROM(rinfo, pdev);
iounmap(rinfo->mmio_base);
err_release_pci:
pci_release_regions(pdev);
err_release_pci2:
pci_release_region(pdev, 2);
err_release_pci0:
pci_release_region(pdev, 0);
err_release_fb:
framebuffer_release(info);
framebuffer_release(info);
err_disable:
pci_disable_device(pdev);
err_out:
Expand Down Expand Up @@ -2548,7 +2558,8 @@ static void __devexit radeonfb_pci_unregister (struct pci_dev *pdev)
iounmap(rinfo->mmio_base);
iounmap(rinfo->fb_base);

pci_release_regions(pdev);
pci_release_region(pdev, 2);
pci_release_region(pdev, 0);

kfree(rinfo->mon1_EDID);
kfree(rinfo->mon2_EDID);
Expand Down

0 comments on commit a5de957

Please sign in to comment.