Skip to content

Commit

Permalink
Staging: rtl8187se: Do not mess with carrier settings while scanning
Browse files Browse the repository at this point in the history
Toggling the link carrier is a non sense and is the grossest locking I can
think of. Moreover, it's giving a completely inaccurate status to userspace
who could for example decide to turn the interface down on carrier off
detection.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Samuel Ortiz authored and Greg Kroah-Hartman committed May 11, 2010
1 parent 592010b commit a5e135b
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,6 @@ void ieee80211_wx_sync_scan_wq(struct work_struct *work)

chan = ieee->current_network.channel;

netif_carrier_off(ieee->dev);

if (ieee->data_hard_stop)
ieee->data_hard_stop(ieee->dev);

Expand All @@ -300,8 +298,6 @@ void ieee80211_wx_sync_scan_wq(struct work_struct *work)
if(ieee->iw_mode == IW_MODE_ADHOC || ieee->iw_mode == IW_MODE_MASTER)
ieee80211_start_send_beacons(ieee);

netif_carrier_on(ieee->dev);

//YJ,add,080828, In prevent of lossing ping packet during scanning
//ieee80211_sta_ps_send_null_frame(ieee, false);
//YJ,add,080828,end
Expand Down

0 comments on commit a5e135b

Please sign in to comment.