Skip to content

Commit

Permalink
SUNRPC: Dead code in net/sunrpc/auth_gss/auth_gss.c
Browse files Browse the repository at this point in the history
Hi,

the coverity checker spotted that cred is always NULL
when we jump to out_err ( there is just one case, when
we fail to allocate the memory for cred )
This is Coverity ID #79

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Eric Sesterhenn authored and Trond Myklebust committed Apr 19, 2006
1 parent 7451c4f commit a5f9145
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion net/sunrpc/auth_gss/auth_gss.c
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,6 @@ gss_create_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags)

out_err:
dprintk("RPC: gss_create_cred failed with error %d\n", err);
if (cred) gss_destroy_cred(&cred->gc_base);
return ERR_PTR(err);
}

Expand Down

0 comments on commit a5f9145

Please sign in to comment.