Skip to content

Commit

Permalink
Staging: hv: Properly capture the error state
Browse files Browse the repository at this point in the history
Properly capture the error state after the completion of I/O. This fixes a bug
that was introduced in the patch-set titled:
Staging: hv: Cleanup-storage-drivers-phase-II.
A corrected version of this patch-set was sent out earlier, however
the earlier (buggy) version of this patch-set was already applied.
This patch fixes the problem.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Apr 20, 2011
1 parent 03068ff commit a617e39
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions drivers/staging/hv/storvsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ static void stor_vsc_on_io_completion(struct hv_device *device,
struct hv_storvsc_request *request)
{
struct storvsc_device *stor_device;
struct vstor_packet *stor_pkt;

stor_device = must_get_stor_device(device);
if (!stor_device) {
Expand All @@ -287,19 +288,24 @@ static void stor_vsc_on_io_completion(struct hv_device *device,
return;
}

DPRINT_DBG(STORVSC, "IO_COMPLETE_OPERATION - request %p "
DPRINT_DBG(STORVSC, "IO_COMPLETE_OPERATION - request %p "
"completed bytes xfer %u", request,
vstor_packet->vm_srb.data_transfer_length);

stor_pkt = &request->vstor_packet;


/* Copy over the status...etc */
stor_pkt->vm_srb.scsi_status = vstor_packet->vm_srb.scsi_status;
stor_pkt->vm_srb.srb_status = vstor_packet->vm_srb.srb_status;
stor_pkt->vm_srb.sense_info_length =
vstor_packet->vm_srb.sense_info_length;

if (vstor_packet->vm_srb.scsi_status != 0 ||
vstor_packet->vm_srb.srb_status != 1) {
DPRINT_WARN(STORVSC,
"cmd 0x%x scsi status 0x%x srb status 0x%x\n",
vstor_packet->vm_srb.cdb[0],
stor_pkt->vm_srb.cdb[0],
vstor_packet->vm_srb.scsi_status,
vstor_packet->vm_srb.srb_status);
}
Expand All @@ -319,6 +325,8 @@ static void stor_vsc_on_io_completion(struct hv_device *device,
}
}

stor_pkt->vm_srb.data_transfer_length =
vstor_packet->vm_srb.data_transfer_length;

request->on_io_completion(request);

Expand Down Expand Up @@ -535,6 +543,7 @@ int stor_vsc_on_io_request(struct hv_device *device,

request->device = device;


vstor_packet->flags |= REQUEST_COMPLETION_FLAG;

vstor_packet->vm_srb.length = sizeof(struct vmscsi_request);
Expand Down

0 comments on commit a617e39

Please sign in to comment.