Skip to content

Commit

Permalink
libertas: make some functions void
Browse files Browse the repository at this point in the history
They don't return anything meaningfull and no-one cares about their results.

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Holger Schurig authored and John W. Linville committed May 7, 2008
1 parent 5f505d9 commit a63e5cb
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion drivers/net/wireless/libertas/cmd.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ int lbs_mesh_config(struct lbs_private *priv, uint16_t enable, uint16_t chan);

int lbs_host_sleep_cfg(struct lbs_private *priv, uint32_t criteria);
int lbs_suspend(struct lbs_private *priv);
int lbs_resume(struct lbs_private *priv);
void lbs_resume(struct lbs_private *priv);

int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
uint16_t cmd_action, uint16_t *timeout);
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/wireless/libertas/decl.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ void lbs_send_iwevcustom_event(struct lbs_private *priv, s8 *str);
struct chan_freq_power *lbs_get_region_cfp_table(u8 region,
int *cfp_no);
struct lbs_private *lbs_add_card(void *card, struct device *dmdev);
int lbs_remove_card(struct lbs_private *priv);
void lbs_remove_card(struct lbs_private *priv);
int lbs_start_card(struct lbs_private *priv);
int lbs_stop_card(struct lbs_private *priv);
void lbs_stop_card(struct lbs_private *priv);
void lbs_host_to_card_done(struct lbs_private *priv);

int lbs_update_channel(struct lbs_private *priv);
Expand Down
12 changes: 4 additions & 8 deletions drivers/net/wireless/libertas/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ int lbs_suspend(struct lbs_private *priv)
}
EXPORT_SYMBOL_GPL(lbs_suspend);

int lbs_resume(struct lbs_private *priv)
void lbs_resume(struct lbs_private *priv)
{
lbs_deb_enter(LBS_DEB_FW);

Expand All @@ -905,7 +905,6 @@ int lbs_resume(struct lbs_private *priv)
netif_device_attach(priv->mesh_dev);

lbs_deb_leave(LBS_DEB_FW);
return 0;
}
EXPORT_SYMBOL_GPL(lbs_resume);

Expand Down Expand Up @@ -1155,7 +1154,7 @@ struct lbs_private *lbs_add_card(void *card, struct device *dmdev)
EXPORT_SYMBOL_GPL(lbs_add_card);


int lbs_remove_card(struct lbs_private *priv)
void lbs_remove_card(struct lbs_private *priv)
{
struct net_device *dev = priv->dev;
union iwreq_data wrqu;
Expand Down Expand Up @@ -1190,7 +1189,6 @@ int lbs_remove_card(struct lbs_private *priv)
free_netdev(dev);

lbs_deb_leave(LBS_DEB_MAIN);
return 0;
}
EXPORT_SYMBOL_GPL(lbs_remove_card);

Expand Down Expand Up @@ -1261,10 +1259,9 @@ int lbs_start_card(struct lbs_private *priv)
EXPORT_SYMBOL_GPL(lbs_start_card);


int lbs_stop_card(struct lbs_private *priv)
void lbs_stop_card(struct lbs_private *priv)
{
struct net_device *dev = priv->dev;
int ret = -1;
struct cmd_ctrl_node *cmdnode;
unsigned long flags;

Expand All @@ -1289,8 +1286,7 @@ int lbs_stop_card(struct lbs_private *priv)

unregister_netdev(dev);

lbs_deb_leave_args(LBS_DEB_MAIN, "ret %d", ret);
return ret;
lbs_deb_leave(LBS_DEB_MAIN);
}
EXPORT_SYMBOL_GPL(lbs_stop_card);

Expand Down

0 comments on commit a63e5cb

Please sign in to comment.