Skip to content

Commit

Permalink
arm: kirkwood: sheevaplug: move pinmux configs to the right devices
Browse files Browse the repository at this point in the history
When the pinmux mechanism was added in Kirkwood, the device driver
core was not yet providing the possibility of attaching pinmux
configurations to all devices, drivers had to do it explicitly, and
not all drivers were doing this.

Now that the driver core does that in a generic way, it makes sense to
attach the pinmux configuration to their corresponding devices.

Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
  • Loading branch information
Simon Baatz authored and Jason Cooper committed Jun 5, 2013
1 parent be5a938 commit a649277
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 29 deletions.
16 changes: 6 additions & 10 deletions arch/arm/boot/dts/kirkwood-sheevaplug-common.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,14 @@
};
};
serial@12000 {
pinctrl-0 = <&pmx_uart0>;
pinctrl-names = "default";
status = "okay";
};

nand@3000000 {
pinctrl-0 = <&pmx_nand>;
pinctrl-names = "default";
status = "okay";

partition@0 {
Expand All @@ -71,6 +75,8 @@
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <0>;
pinctrl-0 = <&pmx_usb_power_enable>;
pinctrl-names = "default";

usb_power: regulator@1 {
compatible = "regulator-fixed";
Expand All @@ -84,14 +90,4 @@
gpio = <&gpio0 29 0>;
};
};

gpio-leds {
compatible = "gpio-leds";

health {
label = "sheevaplug:blue:health";
gpios = <&gpio1 17 1>;
linux,default-trigger = "default-on";
};
};
};
21 changes: 12 additions & 9 deletions arch/arm/boot/dts/kirkwood-sheevaplug-esata.dts
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@
compatible = "globalscale,sheevaplug-esata-rev13", "globalscale,sheevaplug-esata", "globalscale,sheevaplug", "marvell,kirkwood-88f6281", "marvell,kirkwood";

ocp@f1000000 {
pinctrl: pinctrl@10000 {

pinctrl-0 = < &pmx_nand &pmx_uart0
&pmx_usb_power_enable
&pmx_led_blue>;
pinctrl-names = "default";

};

sata@80000 {
status = "okay";
nr-ports = <2>;
Expand All @@ -37,4 +28,16 @@
wp-gpios = <&gpio1 15 0>;
};
};

gpio-leds {
compatible = "gpio-leds";
pinctrl-0 = <&pmx_led_blue>;
pinctrl-names = "default";

health {
label = "sheevaplug:blue:health";
gpios = <&gpio1 17 1>;
linux,default-trigger = "default-on";
};
};
};
18 changes: 8 additions & 10 deletions arch/arm/boot/dts/kirkwood-sheevaplug.dts
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@
compatible = "globalscale,sheevaplug", "marvell,kirkwood-88f6281", "marvell,kirkwood";

ocp@f1000000 {
pinctrl: pinctrl@10000 {

pinctrl-0 = < &pmx_nand &pmx_uart0
&pmx_usb_power_enable
&pmx_led_red
&pmx_led_blue>;
pinctrl-names = "default";

};

mvsdio@90000 {
pinctrl-0 = <&pmx_sdio>;
pinctrl-names = "default";
Expand All @@ -36,6 +26,14 @@

gpio-leds {
compatible = "gpio-leds";
pinctrl-0 = <&pmx_led_blue &pmx_led_red>;
pinctrl-names = "default";

health {
label = "sheevaplug:blue:health";
gpios = <&gpio1 17 1>;
linux,default-trigger = "default-on";
};

misc {
label = "sheevaplug:red:misc";
Expand Down

0 comments on commit a649277

Please sign in to comment.