Skip to content

Commit

Permalink
perf tools: Fix possible (unlikely) buffer overflow
Browse files Browse the repository at this point in the history
cppcheck reported:
[tools/perf/util/sysfs.c:50]: (error) Width 4096 given in format string
(no. 1) is larger than destination buffer 'sysfs_mountpoint[4096]',
use %4095s to prevent overflowing it

-> All other places in the kernel that use STR(PATH_MAX)
   have a buffer size of PATH_MAX + 1.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Link: http://lkml.kernel.org/r/50D9D30B.8090002@intra2net.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Thomas Jarosch authored and Arnaldo Carvalho de Melo committed Jan 24, 2013
1 parent 31160d7 commit a65c234
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/util/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ static const char * const sysfs_known_mountpoints[] = {
};

static int sysfs_found;
char sysfs_mountpoint[PATH_MAX];
char sysfs_mountpoint[PATH_MAX + 1];

static int sysfs_valid_mountpoint(const char *sysfs)
{
Expand Down

0 comments on commit a65c234

Please sign in to comment.