Skip to content

Commit

Permalink
usb: dwc3: gadget: Fix BUG in RT config
Browse files Browse the repository at this point in the history
Using spin_lock() in hard irq handler is pointless
and causes a BUG() in RT (real-time) configuration
so get rid of it.

The reason it's pointless is because the driver is
basically accessing register which is, anyways,
atomic.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Roger Quadros authored and Felipe Balbi committed Sep 21, 2015
1 parent b431ba8 commit a66c275
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/usb/dwc3/gadget.c
Original file line number Diff line number Diff line change
Expand Up @@ -2665,8 +2665,6 @@ static irqreturn_t dwc3_interrupt(int irq, void *_dwc)
int i;
irqreturn_t ret = IRQ_NONE;

spin_lock(&dwc->lock);

for (i = 0; i < dwc->num_event_buffers; i++) {
irqreturn_t status;

Expand All @@ -2675,8 +2673,6 @@ static irqreturn_t dwc3_interrupt(int irq, void *_dwc)
ret = status;
}

spin_unlock(&dwc->lock);

return ret;
}

Expand Down

0 comments on commit a66c275

Please sign in to comment.