Skip to content

Commit

Permalink
Bluetooth: mgmt: Avoid using magic number in status code
Browse files Browse the repository at this point in the history 
Use MGMT_STATUS_SUCCESS for success return code.

Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
  • Loading branch information
Szymon Janc authored and Gustavo Padovan committed Jan 9, 2013
1 parent 47c3794 commit a6785be
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/bluetooth/mgmt.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2259,7 +2259,7 @@ static int add_remote_oob_data(struct sock *sk, struct hci_dev *hdev,
if (err < 0)
status = MGMT_STATUS_FAILED;
else
status = 0;
status = MGMT_STATUS_SUCCESS;

err = cmd_complete(sk, hdev->id, MGMT_OP_ADD_REMOTE_OOB_DATA, status,
&cp->addr, sizeof(cp->addr));
Expand All @@ -2283,7 +2283,7 @@ static int remove_remote_oob_data(struct sock *sk, struct hci_dev *hdev,
if (err < 0)
status = MGMT_STATUS_INVALID_PARAMS;
else
status = 0;
status = MGMT_STATUS_SUCCESS;

err = cmd_complete(sk, hdev->id, MGMT_OP_REMOVE_REMOTE_OOB_DATA,
status, &cp->addr, sizeof(cp->addr));
Expand Down Expand Up @@ -2515,7 +2515,7 @@ static int block_device(struct sock *sk, struct hci_dev *hdev, void *data,
if (err < 0)
status = MGMT_STATUS_FAILED;
else
status = 0;
status = MGMT_STATUS_SUCCESS;

err = cmd_complete(sk, hdev->id, MGMT_OP_BLOCK_DEVICE, status,
&cp->addr, sizeof(cp->addr));
Expand All @@ -2540,7 +2540,7 @@ static int unblock_device(struct sock *sk, struct hci_dev *hdev, void *data,
if (err < 0)
status = MGMT_STATUS_INVALID_PARAMS;
else
status = 0;
status = MGMT_STATUS_SUCCESS;

err = cmd_complete(sk, hdev->id, MGMT_OP_UNBLOCK_DEVICE, status,
&cp->addr, sizeof(cp->addr));
Expand Down

0 comments on commit a6785be

Please sign in to comment.