Skip to content

Commit

Permalink
[IA64] Kernel parameter for max number of concurrent global TLB purges
Browse files Browse the repository at this point in the history
The patch defines kernel parameter "nptcg=". The parameter overrides max number
of concurrent global TLB purges which is reported from either PAL_VM_SUMMARY or
SAL PALO.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Fenghua Yu authored and Tony Luck committed Apr 4, 2008
1 parent 2046b94 commit a6c75b8
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 7 deletions.
4 changes: 4 additions & 0 deletions Documentation/kernel-parameters.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1335,6 +1335,10 @@ and is between 256 and 4096 characters. It is defined in the file

nowb [ARM]

nptcg= [IA64] Override max number of concurrent global TLB
purges which is reported from either PAL_VM_SUMMARY or
SAL PALO.

numa_zonelist_order= [KNL, BOOT] Select zonelist order for NUMA.
one of ['zone', 'node', 'default'] can be specified
This can be set from sysctl after boot.
Expand Down
2 changes: 1 addition & 1 deletion arch/ia64/kernel/efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ static void __init handle_palo(unsigned long palo_phys)
return;
}

setup_ptcg_sem(palo->max_tlb_purges, 1);
setup_ptcg_sem(palo->max_tlb_purges, NPTCG_FROM_PALO);
}

void
Expand Down
2 changes: 1 addition & 1 deletion arch/ia64/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@ cpu_init (void)
/* set ia64_ctx.max_rid to the maximum RID that is supported by all CPUs: */
if (ia64_pal_vm_summary(NULL, &vmi) == 0) {
max_ctx = (1U << (vmi.pal_vm_info_2_s.rid_size - 3)) - 1;
setup_ptcg_sem(vmi.pal_vm_info_2_s.max_purges, 0);
setup_ptcg_sem(vmi.pal_vm_info_2_s.max_purges, NPTCG_FROM_PAL);
} else {
printk(KERN_WARNING "cpu_init: PAL VM summary failed, assuming 18 RID bits\n");
max_ctx = (1U << 15) - 1; /* use architected minimum */
Expand Down
46 changes: 41 additions & 5 deletions arch/ia64/mm/tlb.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,29 +119,65 @@ static u16 nptcg = 1;
static int need_ptcg_sem = 1;
static int toolatetochangeptcgsem = 0;

/*
* Kernel parameter "nptcg=" overrides max number of concurrent global TLB
* purges which is reported from either PAL or SAL PALO.
*
* We don't have sanity checking for nptcg value. It's the user's responsibility
* for valid nptcg value on the platform. Otherwise, kernel may hang in some
* cases.
*/
static int __init
set_nptcg(char *str)
{
int value = 0;

get_option(&str, &value);
setup_ptcg_sem(value, NPTCG_FROM_KERNEL_PARAMETER);

return 1;
}

__setup("nptcg=", set_nptcg);

/*
* Maximum number of simultaneous ptc.g purges in the system can
* be defined by PAL_VM_SUMMARY (in which case we should take
* the smallest value for any cpu in the system) or by the PAL
* override table (in which case we should ignore the value from
* PAL_VM_SUMMARY).
*
* Kernel parameter "nptcg=" overrides maximum number of simultanesous ptc.g
* purges defined in either PAL_VM_SUMMARY or PAL override table. In this case,
* we should ignore the value from either PAL_VM_SUMMARY or PAL override table.
*
* Complicating the logic here is the fact that num_possible_cpus()
* isn't fully setup until we start bringing cpus online.
*/
void
setup_ptcg_sem(int max_purges, int from_palo)
setup_ptcg_sem(int max_purges, int nptcg_from)
{
static int have_palo;
static int kp_override;
static int palo_override;
static int firstcpu = 1;

if (toolatetochangeptcgsem) {
BUG_ON(max_purges < nptcg);
return;
}

if (from_palo) {
have_palo = 1;
if (nptcg_from == NPTCG_FROM_KERNEL_PARAMETER) {
kp_override = 1;
nptcg = max_purges;
goto resetsema;
}
if (kp_override) {
need_ptcg_sem = num_possible_cpus() > nptcg;
return;
}

if (nptcg_from == NPTCG_FROM_PALO) {
palo_override = 1;

/* In PALO max_purges == 0 really means it! */
if (max_purges == 0)
Expand All @@ -153,7 +189,7 @@ setup_ptcg_sem(int max_purges, int from_palo)
}
goto resetsema;
}
if (have_palo) {
if (palo_override) {
if (nptcg != PALO_MAX_TLB_PURGES)
need_ptcg_sem = (num_possible_cpus() > nptcg);
return;
Expand Down
4 changes: 4 additions & 0 deletions include/asm-ia64/sal.h
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,10 @@ struct palo_table {
u8 reserved2[6];
};

#define NPTCG_FROM_PAL 0
#define NPTCG_FROM_PALO 1
#define NPTCG_FROM_KERNEL_PARAMETER 2

#endif /* __ASSEMBLY__ */

#endif /* _ASM_IA64_SAL_H */

0 comments on commit a6c75b8

Please sign in to comment.