Skip to content

Commit

Permalink
[SCSI] esp: fix eh locking
Browse files Browse the repository at this point in the history
esp_reset didn't get fixed when the EH locking changed.
->eh_bus_reset_handler is now called without the host lock held.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Christoph Hellwig authored and David S. Miller committed Feb 22, 2006
1 parent c45ec65 commit a6ceda7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/scsi/esp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2068,14 +2068,12 @@ static int esp_reset(struct scsi_cmnd *SCptr)
{
struct esp *esp = (struct esp *) SCptr->device->host->hostdata;

spin_lock_irq(esp->ehost->host_lock);
(void) esp_do_resetbus(esp);

spin_unlock_irq(esp->ehost->host_lock);

wait_event(esp->reset_queue, (esp->resetting_bus == 0));

spin_lock_irq(esp->ehost->host_lock);

return SUCCESS;
}

Expand Down

0 comments on commit a6ceda7

Please sign in to comment.