Skip to content

Commit

Permalink
NFSv4: Get rid of the bogus RPC_ASSASSINATED(task) checks
Browse files Browse the repository at this point in the history
There is no real reason to have RPC_ASSASSINATED() checks in the NFS code.
As far as it is concerned, this is just an RPC error...

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Trond Myklebust authored and Trond Myklebust committed Aug 4, 2010
1 parent 452e935 commit a6f0339
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions fs/nfs/nfs4proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1275,8 +1275,6 @@ static void nfs4_open_confirm_done(struct rpc_task *task, void *calldata)
struct nfs4_opendata *data = calldata;

data->rpc_status = task->tk_status;
if (RPC_ASSASSINATED(task))
return;
if (data->rpc_status == 0) {
memcpy(data->o_res.stateid.data, data->c_res.stateid.data,
sizeof(data->o_res.stateid.data));
Expand Down Expand Up @@ -1408,8 +1406,6 @@ static void nfs4_open_done(struct rpc_task *task, void *calldata)
if (!nfs4_sequence_done(task, &data->o_res.seq_res))
return;

if (RPC_ASSASSINATED(task))
return;
if (task->tk_status == 0) {
switch (data->o_res.f_attr->mode & S_IFMT) {
case S_IFREG:
Expand Down Expand Up @@ -1860,8 +1856,6 @@ static void nfs4_close_done(struct rpc_task *task, void *data)

if (!nfs4_sequence_done(task, &calldata->res.seq_res))
return;
if (RPC_ASSASSINATED(task))
return;
/* hmm. we are done with the inode, and in the process of freeing
* the state_owner. we keep this around to process errors
*/
Expand Down Expand Up @@ -3907,8 +3901,6 @@ static void nfs4_locku_done(struct rpc_task *task, void *data)

if (!nfs4_sequence_done(task, &calldata->res.seq_res))
return;
if (RPC_ASSASSINATED(task))
return;
switch (task->tk_status) {
case 0:
memcpy(calldata->lsp->ls_stateid.data,
Expand Down Expand Up @@ -4119,8 +4111,6 @@ static void nfs4_lock_done(struct rpc_task *task, void *calldata)
return;

data->rpc_status = task->tk_status;
if (RPC_ASSASSINATED(task))
goto out;
if (data->arg.new_lock_owner != 0) {
if (data->rpc_status == 0)
nfs_confirm_seqid(&data->lsp->ls_seqid, 0);
Expand Down

0 comments on commit a6f0339

Please sign in to comment.