Skip to content

Commit

Permalink
[PATCH] uml: fix timer initialization
Browse files Browse the repository at this point in the history
In skas mode, the call to uml_idle_timer permanently shut off the virtual
timer, resulting in no timer ticks to anything but the idle thread.  This is
likely the cause of the soft lockups that are seen sporadically in recent
UMLs.

Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jeff Dike authored and Linus Torvalds committed Jun 25, 2005
1 parent e0877f0 commit a6f4e3c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion arch/um/kernel/process_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ int current_pid(void)

void default_idle(void)
{
uml_idle_timer();
CHOOSE_MODE(uml_idle_timer(), (void) 0);

atomic_inc(&init_mm.mm_count);
current->mm = &init_mm;
Expand Down
1 change: 0 additions & 1 deletion arch/um/kernel/skas/process_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ int start_uml_skas(void)
start_userspace(0);

init_new_thread_signals(1);
uml_idle_timer();

init_task.thread.request.u.thread.proc = start_kernel_proc;
init_task.thread.request.u.thread.arg = NULL;
Expand Down

0 comments on commit a6f4e3c

Please sign in to comment.