Skip to content

Commit

Permalink
posix-timers: Convert timer_gettime() to clockid_to_kclock()
Browse files Browse the repository at this point in the history
Set the common function for CLOCK_MONOTONIC and CLOCK_REALTIME kclocks
and use the new decoding function.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: John Stultz <johnstul@us.ibm.com>
Tested-by: Richard Cochran <richard.cochran@omicron.at>
LKML-Reference: <20110201134419.101243181@linutronix.de>
  • Loading branch information
Thomas Gleixner committed Feb 2, 2011
1 parent 27722df commit a7319fa
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions kernel/posix-timers.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ static __init int init_posix_timers(void)
.nsleep_restart = hrtimer_nanosleep_restart,
.timer_create = common_timer_create,
.timer_set = common_timer_set,
.timer_get = common_timer_get,
};
struct k_clock clock_monotonic = {
.clock_getres = hrtimer_get_res,
Expand All @@ -261,6 +262,7 @@ static __init int init_posix_timers(void)
.nsleep_restart = hrtimer_nanosleep_restart,
.timer_create = common_timer_create,
.timer_set = common_timer_set,
.timer_get = common_timer_get,
};
struct k_clock clock_monotonic_raw = {
.clock_getres = hrtimer_get_res,
Expand Down Expand Up @@ -712,22 +714,28 @@ common_timer_get(struct k_itimer *timr, struct itimerspec *cur_setting)
SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id,
struct itimerspec __user *, setting)
{
struct k_itimer *timr;
struct itimerspec cur_setting;
struct k_itimer *timr;
struct k_clock *kc;
unsigned long flags;
int ret = 0;

timr = lock_timer(timer_id, &flags);
if (!timr)
return -EINVAL;

CLOCK_DISPATCH(timr->it_clock, timer_get, (timr, &cur_setting));
kc = clockid_to_kclock(timr->it_clock);
if (WARN_ON_ONCE(!kc || !kc->timer_get))
ret = -EINVAL;
else
kc->timer_get(timr, &cur_setting);

unlock_timer(timr, flags);

if (copy_to_user(setting, &cur_setting, sizeof (cur_setting)))
if (!ret && copy_to_user(setting, &cur_setting, sizeof (cur_setting)))
return -EFAULT;

return 0;
return ret;
}

/*
Expand Down

0 comments on commit a7319fa

Please sign in to comment.