Skip to content

Commit

Permalink
[ARM] 4326/1: S3C24XX: fix sparse errors in DMA code
Browse files Browse the repository at this point in the history
Fix the following sparse errors in arch/arm/plat-s3c24xx/dma.c:

dma.c:47:30: warning: symbol 'dma_sel' was not declared. Should it be static?
dma.c:883:6: warning: symbol 's3c2410_dma_waitforstop' was not declared. Should it be static?
dma.c:961:1: warning: symbol 's3c2410_dma_started' was not declared. Should it be static?
dma.c:1283:12: warning: symbol 's3c24xx_dma_sysclass_init' was not declared. Should it be static?
dma.c:1295:12: warning: symbol 's3c24xx_dma_sysdev_register' was not declared. Should it be static?
dma.c:1399:25: warning: symbol 's3c2410_dma_map_channel' was not declared. Should it be static?

The patch makes all the relevant functions static.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Ben Dooks authored and Russell King committed Apr 21, 2007
1 parent 57e5171 commit a771743
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions arch/arm/plat-s3c24xx/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ static struct kmem_cache *dma_kmem;

static int dma_channels;

struct s3c24xx_dma_selection dma_sel;
static struct s3c24xx_dma_selection dma_sel;

/* dma channel state information */
struct s3c2410_dma_chan s3c2410_chans[S3C2410_DMA_CHANNELS];
Expand Down Expand Up @@ -880,7 +880,7 @@ static int s3c2410_dma_dostop(struct s3c2410_dma_chan *chan)
return 0;
}

void s3c2410_dma_waitforstop(struct s3c2410_dma_chan *chan)
static void s3c2410_dma_waitforstop(struct s3c2410_dma_chan *chan)
{
unsigned long tmp;
unsigned int timeout = 0x10000;
Expand Down Expand Up @@ -957,8 +957,7 @@ static int s3c2410_dma_flush(struct s3c2410_dma_chan *chan)
return 0;
}

int
s3c2410_dma_started(struct s3c2410_dma_chan *chan)
static int s3c2410_dma_started(struct s3c2410_dma_chan *chan)
{
unsigned long flags;

Expand Down Expand Up @@ -1280,7 +1279,7 @@ static void s3c2410_dma_cache_ctor(void *p, struct kmem_cache *c, unsigned long

/* initialisation code */

int __init s3c24xx_dma_sysclass_init(void)
static int __init s3c24xx_dma_sysclass_init(void)
{
int ret = sysdev_class_register(&dma_sysclass);

Expand All @@ -1292,7 +1291,7 @@ int __init s3c24xx_dma_sysclass_init(void)

core_initcall(s3c24xx_dma_sysclass_init);

int __init s3c24xx_dma_sysdev_register(void)
static int __init s3c24xx_dma_sysdev_register(void)
{
struct s3c2410_dma_chan *cp = s3c2410_chans;
int channel, ret;
Expand Down Expand Up @@ -1396,7 +1395,7 @@ static struct s3c24xx_dma_order *dma_order;
* channel
*/

struct s3c2410_dma_chan *s3c2410_dma_map_channel(int channel)
static struct s3c2410_dma_chan *s3c2410_dma_map_channel(int channel)
{
struct s3c24xx_dma_order_ch *ord = NULL;
struct s3c24xx_dma_map *ch_map;
Expand Down

0 comments on commit a771743

Please sign in to comment.