Skip to content

Commit

Permalink
sky2: receive error handling improvements
Browse files Browse the repository at this point in the history
Don't drop oversize frame it might be a VLAN (untagged).
Use different counter for fifo overrun vs fifo error.
Print error on fifo overrrun.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Stephen Hemminger authored and Jeff Garzik committed Feb 17, 2007
1 parent 8190679 commit a79abdc
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -2056,9 +2056,6 @@ static struct sk_buff *sky2_receive(struct net_device *dev,
if (!(status & GMR_FS_RX_OK))
goto resubmit;

if (length > dev->mtu + ETH_HLEN)
goto oversize;

if (length < copybreak)
skb = receive_copy(sky2, re, length);
else
Expand All @@ -2068,14 +2065,10 @@ static struct sk_buff *sky2_receive(struct net_device *dev,

return skb;

oversize:
++sky2->net_stats.rx_over_errors;
goto resubmit;

error:
++sky2->net_stats.rx_errors;
if (status & GMR_FS_RX_FF_OV) {
sky2->net_stats.rx_fifo_errors++;
sky2->net_stats.rx_over_errors++;
goto resubmit;
}

Expand Down

0 comments on commit a79abdc

Please sign in to comment.