Skip to content

Commit

Permalink
sky2: restore multicast addresses after recovery
Browse files Browse the repository at this point in the history
If the sky2 deadman timer forces a recovery, the multicast hash
list is lost. Move the call to sky2_set_multicast to the end
of sky2_up() so all paths that bring device up will restore multicast.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Feb 3, 2008
1 parent 44911bf commit a7bffe7
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -1422,6 +1422,7 @@ static int sky2_up(struct net_device *dev)
imask |= portirq_msk[port];
sky2_write32(hw, B0_IMSK, imask);

sky2_set_multicast(dev);
return 0;

err_out:
Expand Down Expand Up @@ -3554,8 +3555,6 @@ static int sky2_set_ringparam(struct net_device *dev,
err = sky2_up(dev);
if (err)
dev_close(dev);
else
sky2_set_multicast(dev);
}

return err;
Expand Down Expand Up @@ -4389,8 +4388,6 @@ static int sky2_resume(struct pci_dev *pdev)
dev_close(dev);
goto out;
}

sky2_set_multicast(dev);
}
}

Expand Down

0 comments on commit a7bffe7

Please sign in to comment.