Skip to content

Commit

Permalink
Staging: bcm: Bcmchar: Fix style issues on bcm_char_release()
Browse files Browse the repository at this point in the history
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Javier Martinez Canillas authored and Greg Kroah-Hartman committed Feb 18, 2011
1 parent 1e12332 commit a7d3976
Showing 1 changed file with 31 additions and 37 deletions.
68 changes: 31 additions & 37 deletions drivers/staging/bcm/Bcmchar.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,61 +45,55 @@ static int bcm_char_open(struct inode *inode, struct file * filp)

static int bcm_char_release(struct inode *inode, struct file *filp)
{
PPER_TARANG_DATA pTarang, tmp, ptmp;
PMINI_ADAPTER Adapter=NULL;
struct sk_buff * pkt, * npkt;
PPER_TARANG_DATA pTarang, tmp, ptmp;
PMINI_ADAPTER Adapter = NULL;
struct sk_buff *pkt, *npkt;

pTarang = (PPER_TARANG_DATA)filp->private_data;
pTarang = (PPER_TARANG_DATA)filp->private_data;

if(pTarang == NULL)
{
BCM_DEBUG_PRINT(Adapter,DBG_TYPE_PRINTK, 0, 0, "ptarang is null\n");
return 0;
if (pTarang == NULL) {
BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
"ptarang is null\n");
return 0;
}

Adapter = pTarang->Adapter;

down( &Adapter->RxAppControlQueuelock);
down(&Adapter->RxAppControlQueuelock);

tmp = Adapter->pTarangs;
for ( ptmp = NULL; tmp; ptmp = tmp, tmp = tmp->next )
{
if ( tmp == pTarang )
tmp = Adapter->pTarangs;
for (ptmp = NULL; tmp; ptmp = tmp, tmp = tmp->next) {
if (tmp == pTarang)
break;
}

if ( tmp )
{
if ( !ptmp )
Adapter->pTarangs = tmp->next;
else
ptmp->next = tmp->next;
if (tmp) {
if (!ptmp)
Adapter->pTarangs = tmp->next;
else
ptmp->next = tmp->next;
} else {
up(&Adapter->RxAppControlQueuelock);
return 0;
}

else
{
up( &Adapter->RxAppControlQueuelock);
return 0;
}

pkt = pTarang->RxAppControlHead;
while ( pkt )
{
npkt = pkt->next;
kfree_skb(pkt);
pkt = npkt;
pkt = pTarang->RxAppControlHead;
while (pkt) {
npkt = pkt->next;
kfree_skb(pkt);
pkt = npkt;
}

up( &Adapter->RxAppControlQueuelock);
up(&Adapter->RxAppControlQueuelock);

/*Stop Queuing the control response Packets*/
atomic_dec(&Adapter->ApplicationRunning);
/*Stop Queuing the control response Packets*/
atomic_dec(&Adapter->ApplicationRunning);

kfree(pTarang);
kfree(pTarang);

/* remove this filp from the asynchronously notified filp's */
filp->private_data = NULL;
return 0;
filp->private_data = NULL;
return 0;
}

static ssize_t bcm_char_read(struct file *filp, char __user *buf, size_t size, loff_t *f_pos)
Expand Down

0 comments on commit a7d3976

Please sign in to comment.