Skip to content

Commit

Permalink
[POWERPC] pseries: device node status can be "ok" or "okay"
Browse files Browse the repository at this point in the history
It seems that some versions of firmware will report a device
node status as the string "okay". As we are not expecting this
string, the device node will be ignored by the EEH subsystem.
Which means EEH will not be enabled.

When EEH is not enabled, PCI errors will be converted into
Machine Check exceptions, and we'll have a very unhappy system.

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Linas Vepstas authored and Paul Mackerras committed Oct 2, 2007
1 parent 576e393 commit a7fb7ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/pseries/eeh.c
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ static void *early_enable_eeh(struct device_node *dn, void *data)
pdn->eeh_freeze_count = 0;
pdn->eeh_false_positives = 0;

if (status && strcmp(status, "ok") != 0)
if (status && strncmp(status, "ok", 2) != 0)
return NULL; /* ignore devices with bad status */

/* Ignore bad nodes. */
Expand Down

0 comments on commit a7fb7ea

Please sign in to comment.