Skip to content

Commit

Permalink
sata_mv ncq Remove post internal cmd op
Browse files Browse the repository at this point in the history
This driver currently has no need for the .post_internal_cmd op.
So get rid of it, to save unnecessary transitions between EDMA and non-EDMA modes.

Signed-off-by: Mark Lord <mlord@pobox.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Mark Lord authored and Jeff Garzik committed Feb 1, 2008
1 parent 138bfdd commit a838b17
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions drivers/ata/sata_mv.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ static void mv_qc_prep(struct ata_queued_cmd *qc);
static void mv_qc_prep_iie(struct ata_queued_cmd *qc);
static unsigned int mv_qc_issue(struct ata_queued_cmd *qc);
static void mv_error_handler(struct ata_port *ap);
static void mv_post_int_cmd(struct ata_queued_cmd *qc);
static void mv_eh_freeze(struct ata_port *ap);
static void mv_eh_thaw(struct ata_port *ap);
static void mv6_dev_config(struct ata_device *dev);
Expand Down Expand Up @@ -541,7 +540,6 @@ static const struct ata_port_operations mv5_ops = {
.irq_on = ata_irq_on,

.error_handler = mv_error_handler,
.post_internal_cmd = mv_post_int_cmd,
.freeze = mv_eh_freeze,
.thaw = mv_eh_thaw,

Expand Down Expand Up @@ -570,7 +568,6 @@ static const struct ata_port_operations mv6_ops = {
.irq_on = ata_irq_on,

.error_handler = mv_error_handler,
.post_internal_cmd = mv_post_int_cmd,
.freeze = mv_eh_freeze,
.thaw = mv_eh_thaw,
.qc_defer = ata_std_qc_defer,
Expand Down Expand Up @@ -599,7 +596,6 @@ static const struct ata_port_operations mv_iie_ops = {
.irq_on = ata_irq_on,

.error_handler = mv_error_handler,
.post_internal_cmd = mv_post_int_cmd,
.freeze = mv_eh_freeze,
.thaw = mv_eh_thaw,
.qc_defer = ata_std_qc_defer,
Expand Down Expand Up @@ -2424,11 +2420,6 @@ static void mv_error_handler(struct ata_port *ap)
mv_hardreset, mv_postreset);
}

static void mv_post_int_cmd(struct ata_queued_cmd *qc)
{
mv_stop_dma(qc->ap);
}

static void mv_eh_freeze(struct ata_port *ap)
{
void __iomem *mmio = ap->host->iomap[MV_PRIMARY_BAR];
Expand Down

0 comments on commit a838b17

Please sign in to comment.