Skip to content

Commit

Permalink
i386: no need to make enable_cpu_hotplug a variable
Browse files Browse the repository at this point in the history
As long as there's no write access to this variable there's no reason to
let gcc check it at runtime.

[ tglx: arch/x86 adaptation ]

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Adrian Bunk authored and Thomas Gleixner committed Oct 17, 2007
1 parent fb7ae26 commit a850cef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 3 additions & 3 deletions arch/x86/kernel/topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ int arch_register_cpu(int num)
* Also certain PCI quirks require not to enable hotplug control
* for all CPU's.
*/
if (num && enable_cpu_hotplug)
#ifdef CONFIG_HOTPLUG_CPU
if (num)
cpu_devices[num].cpu.hotpluggable = 1;
#endif

return register_cpu(&cpu_devices[num].cpu, num);
}

#ifdef CONFIG_HOTPLUG_CPU
int enable_cpu_hotplug = 1;

void arch_unregister_cpu(int num) {
return unregister_cpu(&cpu_devices[num].cpu);
}
Expand Down
3 changes: 0 additions & 3 deletions include/asm-x86/cpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ struct i386_cpu {
extern int arch_register_cpu(int num);
#ifdef CONFIG_HOTPLUG_CPU
extern void arch_unregister_cpu(int);
extern int enable_cpu_hotplug;
#else
#define enable_cpu_hotplug 0
#endif

DECLARE_PER_CPU(int, cpu_state);
Expand Down

0 comments on commit a850cef

Please sign in to comment.