Skip to content

Commit

Permalink
swiotlb: use iommu_is_span_boundary helper function
Browse files Browse the repository at this point in the history
iommu_is_span_boundary in lib/iommu-helper.c was exported for PARISC IOMMUs
(commit 3715863).  SWIOTLB can use it instead
of the homegrown function.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
FUJITA Tomonori authored and Linus Torvalds committed Apr 29, 2008
1 parent a7133a1 commit a852250
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
5 changes: 4 additions & 1 deletion arch/ia64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ config MMU
config SWIOTLB
bool

config IOMMU_HELPER
bool

config GENERIC_LOCKBREAK
bool
default y
Expand Down Expand Up @@ -615,7 +618,7 @@ config IRQ_PER_CPU
default y

config IOMMU_HELPER
def_bool (IA64_HP_ZX1 || IA64_HP_ZX1_SWIOTLB || IA64_GENERIC)
def_bool (IA64_HP_ZX1 || IA64_HP_ZX1_SWIOTLB || IA64_GENERIC || SWIOTLB)

source "arch/ia64/hp/sim/Kconfig"

Expand Down
5 changes: 2 additions & 3 deletions arch/x86/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -537,9 +537,6 @@ config CALGARY_IOMMU_ENABLED_BY_DEFAULT
Calgary anyway, pass 'iommu=calgary' on the kernel command line.
If unsure, say Y.

config IOMMU_HELPER
def_bool (CALGARY_IOMMU || GART_IOMMU)

# need this always selected by IOMMU for the VIA workaround
config SWIOTLB
bool
Expand All @@ -550,6 +547,8 @@ config SWIOTLB
access 32-bits of memory can be used on systems with more than
3 GB of memory. If unsure, say Y.

config IOMMU_HELPER
def_bool (CALGARY_IOMMU || GART_IOMMU || SWIOTLB)

config NR_CPUS
int "Maximum number of CPUs (2-255)"
Expand Down
14 changes: 3 additions & 11 deletions lib/swiotlb.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

#include <linux/init.h>
#include <linux/bootmem.h>
#include <linux/iommu-helper.h>

#define OFFSET(val,align) ((unsigned long) \
( (val) & ( (align) - 1)))
Expand Down Expand Up @@ -282,15 +283,6 @@ address_needs_mapping(struct device *hwdev, dma_addr_t addr)
return (addr & ~mask) != 0;
}

static inline unsigned int is_span_boundary(unsigned int index,
unsigned int nslots,
unsigned long offset_slots,
unsigned long max_slots)
{
unsigned long offset = (offset_slots + index) & (max_slots - 1);
return offset + nslots > max_slots;
}

/*
* Allocates bounce buffer and returns its kernel virtual address.
*/
Expand Down Expand Up @@ -337,8 +329,8 @@ map_single(struct device *hwdev, char *buffer, size_t size, int dir)
wrap = index;

do {
while (is_span_boundary(index, nslots, offset_slots,
max_slots)) {
while (iommu_is_span_boundary(index, nslots, offset_slots,
max_slots)) {
index += stride;
if (index >= io_tlb_nslabs)
index = 0;
Expand Down

0 comments on commit a852250

Please sign in to comment.