Skip to content

Commit

Permalink
ocfs2: fix exit-while-locked bug in ocfs2_queue_orphans()
Browse files Browse the repository at this point in the history
We're holding the cluster lock when a failure might happen in
ocfs2_dir_foreach() so it needs to be released.

Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
  • Loading branch information
Mark Fasheh committed Dec 17, 2007
1 parent ea9e7b5 commit a86370f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/ocfs2/journal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1277,11 +1277,12 @@ static int ocfs2_queue_orphans(struct ocfs2_super *osb,
ocfs2_orphan_filldir);
if (status) {
mlog_errno(status);
goto out;
goto out_cluster;
}

*head = priv.head;

out_cluster:
ocfs2_meta_unlock(orphan_dir_inode, 0);
out:
mutex_unlock(&orphan_dir_inode->i_mutex);
Expand Down

0 comments on commit a86370f

Please sign in to comment.