Skip to content

Commit

Permalink
Merge branch 'pci/ifndefs' into next
Browse files Browse the repository at this point in the history
* pci/ifndefs:
  PCI: Cleanup pci.h whitespace
  PCI: Reorder so actual code comes before stubs
  • Loading branch information
Bjorn Helgaas committed Jan 14, 2014
2 parents 597db6f + 2ee546c commit a870614
Show file tree
Hide file tree
Showing 2 changed files with 93 additions and 230 deletions.
57 changes: 25 additions & 32 deletions drivers/pci/pci-label.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,7 @@

#define DEVICE_LABEL_DSM 0x07

#ifndef CONFIG_DMI

static inline int
pci_create_smbiosname_file(struct pci_dev *pdev)
{
return -1;
}

static inline void
pci_remove_smbiosname_file(struct pci_dev *pdev)
{
}

#else

#ifdef CONFIG_DMI
enum smbios_attr_enum {
SMBIOS_ATTR_NONE = 0,
SMBIOS_ATTR_LABEL_SHOW,
Expand Down Expand Up @@ -156,31 +142,20 @@ pci_remove_smbiosname_file(struct pci_dev *pdev)
{
sysfs_remove_group(&pdev->dev.kobj, &smbios_attr_group);
}

#endif

#ifndef CONFIG_ACPI

static inline int
pci_create_acpi_index_label_files(struct pci_dev *pdev)
{
return -1;
}

#else
static inline int
pci_remove_acpi_index_label_files(struct pci_dev *pdev)
pci_create_smbiosname_file(struct pci_dev *pdev)
{
return -1;
}

static inline bool
device_has_dsm(struct device *dev)
static inline void
pci_remove_smbiosname_file(struct pci_dev *pdev)
{
return false;
}
#endif

#else

#ifdef CONFIG_ACPI
static const char device_label_dsm_uuid[] = {
0xD0, 0x37, 0xC9, 0xE5, 0x53, 0x35, 0x7A, 0x4D,
0x91, 0x17, 0xEA, 0x4D, 0x19, 0xC3, 0x43, 0x4D
Expand Down Expand Up @@ -364,6 +339,24 @@ pci_remove_acpi_index_label_files(struct pci_dev *pdev)
sysfs_remove_group(&pdev->dev.kobj, &acpi_attr_group);
return 0;
}
#else
static inline int
pci_create_acpi_index_label_files(struct pci_dev *pdev)
{
return -1;
}

static inline int
pci_remove_acpi_index_label_files(struct pci_dev *pdev)
{
return -1;
}

static inline bool
device_has_dsm(struct device *dev)
{
return false;
}
#endif

void pci_create_firmware_label_files(struct pci_dev *pdev)
Expand Down
Loading

0 comments on commit a870614

Please sign in to comment.