Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 302238
b: refs/heads/master
c: 5abe0c4
h: refs/heads/master
v: v3
  • Loading branch information
Axel Lin authored and Mark Brown committed Apr 18, 2012
1 parent cc780bc commit a87afa6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 14 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 62bc4d4a702654cf5aefbb32c766991fb45bf15a
refs/heads/master: 5abe0c4005dea3a67051eb1942916f9d0f6a1796
20 changes: 7 additions & 13 deletions trunk/drivers/regulator/userspace-consumer.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev)
if (!pdata)
return -EINVAL;

drvdata = kzalloc(sizeof(struct userspace_consumer_data), GFP_KERNEL);
drvdata = devm_kzalloc(&pdev->dev,
sizeof(struct userspace_consumer_data),
GFP_KERNEL);
if (drvdata == NULL)
return -ENOMEM;

Expand All @@ -125,16 +127,16 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev)

mutex_init(&drvdata->lock);

ret = regulator_bulk_get(&pdev->dev, drvdata->num_supplies,
drvdata->supplies);
ret = devm_regulator_bulk_get(&pdev->dev, drvdata->num_supplies,
drvdata->supplies);
if (ret) {
dev_err(&pdev->dev, "Failed to get supplies: %d\n", ret);
goto err_alloc_supplies;
return ret;
}

ret = sysfs_create_group(&pdev->dev.kobj, &attr_group);
if (ret != 0)
goto err_create_attrs;
return ret;

if (pdata->init_on) {
ret = regulator_bulk_enable(drvdata->num_supplies,
Expand All @@ -154,11 +156,6 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev)
err_enable:
sysfs_remove_group(&pdev->dev.kobj, &attr_group);

err_create_attrs:
regulator_bulk_free(drvdata->num_supplies, drvdata->supplies);

err_alloc_supplies:
kfree(drvdata);
return ret;
}

Expand All @@ -171,9 +168,6 @@ static int regulator_userspace_consumer_remove(struct platform_device *pdev)
if (data->enabled)
regulator_bulk_disable(data->num_supplies, data->supplies);

regulator_bulk_free(data->num_supplies, data->supplies);
kfree(data);

return 0;
}

Expand Down

0 comments on commit a87afa6

Please sign in to comment.