Skip to content

Commit

Permalink
ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
Browse files Browse the repository at this point in the history
In case of error, the function omap_device_alloc() returns ERR_PTR()
and never returns NULL pointer. The NULL test in the return value
check should be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Kevin Hilman <khilman@ti.com>
  • Loading branch information
Wei Yongjun authored and Kevin Hilman committed Oct 2, 2012
1 parent 104c794 commit a87e662
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/plat-omap/omap_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ struct platform_device __init *omap_device_build_ss(const char *pdev_name, int p
dev_set_name(&pdev->dev, "%s", pdev->name);

od = omap_device_alloc(pdev, ohs, oh_cnt, pm_lats, pm_lats_cnt);
if (!od)
if (IS_ERR(od))
goto odbs_exit1;

ret = platform_device_add_data(pdev, pdata, pdata_len);
Expand Down

0 comments on commit a87e662

Please sign in to comment.