Skip to content

Commit

Permalink
jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled
Browse files Browse the repository at this point in the history
Currently jsm is showing the following message when loaded:

IRQ 432/JSM: IRQF_DISABLED is not guaranteed on shared IRQs

It's because the request_irq() is called using IRQF_DISABLED
and IRQF_SHARED.
Actually there is no need to use IRQF_DISABLED in this driver.

Signed-off-by: Breno Leitão <leitao@linux.vnet.ibm.com>
Cc: Scott Kilau <scottk@digi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Breno Leitão authored and Greg Kroah-Hartman committed Dec 11, 2009
1 parent d71cb81 commit a88a477
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/serial/jsm/jsm_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ static int __devinit jsm_probe_one(struct pci_dev *pdev, const struct pci_device
}

rc = request_irq(brd->irq, brd->bd_ops->intr,
IRQF_DISABLED|IRQF_SHARED, "JSM", brd);
IRQF_SHARED, "JSM", brd);
if (rc) {
printk(KERN_WARNING "Failed to hook IRQ %d\n",brd->irq);
goto out_iounmap;
Expand Down

0 comments on commit a88a477

Please sign in to comment.