Skip to content

Commit

Permalink
clk: samsung: Remove unimplemented ops for pll
Browse files Browse the repository at this point in the history 
Unimplemented clock operations should be simply omitted instead of returning
error values.

This patch removes unimplemented PLL operations to fix problems caused
by returning error code in round_rate callback.

Signed-off-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
Acked-by: Mike Turquette <mturquette@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
  • Loading branch information
Tomasz Figa authored and Kukjin Kim committed Apr 4, 2013
1 parent e77ba80 commit a8b5a39
Showing 1 changed file with 0 additions and 80 deletions.
80 changes: 0 additions & 80 deletions drivers/clk/samsung/clk-pll.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,24 +49,8 @@ static unsigned long samsung_pll35xx_recalc_rate(struct clk_hw *hw,
return (unsigned long)fvco;
}

/* todo: implement pl35xx clock round rate operation */
static long samsung_pll35xx_round_rate(struct clk_hw *hw,
unsigned long drate, unsigned long *prate)
{
return -ENOTSUPP;
}

/* todo: implement pl35xx clock set rate */
static int samsung_pll35xx_set_rate(struct clk_hw *hw, unsigned long drate,
unsigned long prate)
{
return -ENOTSUPP;
}

static const struct clk_ops samsung_pll35xx_clk_ops = {
.recalc_rate = samsung_pll35xx_recalc_rate,
.round_rate = samsung_pll35xx_round_rate,
.set_rate = samsung_pll35xx_set_rate,
};

struct clk * __init samsung_clk_register_pll35xx(const char *name,
Expand Down Expand Up @@ -144,24 +128,8 @@ static unsigned long samsung_pll36xx_recalc_rate(struct clk_hw *hw,
return (unsigned long)fvco;
}

/* todo: implement pl36xx clock round rate operation */
static long samsung_pll36xx_round_rate(struct clk_hw *hw,
unsigned long drate, unsigned long *prate)
{
return -ENOTSUPP;
}

/* todo: implement pl36xx clock set rate */
static int samsung_pll36xx_set_rate(struct clk_hw *hw, unsigned long drate,
unsigned long prate)
{
return -ENOTSUPP;
}

static const struct clk_ops samsung_pll36xx_clk_ops = {
.recalc_rate = samsung_pll36xx_recalc_rate,
.round_rate = samsung_pll36xx_round_rate,
.set_rate = samsung_pll36xx_set_rate,
};

struct clk * __init samsung_clk_register_pll36xx(const char *name,
Expand Down Expand Up @@ -239,24 +207,8 @@ static unsigned long samsung_pll45xx_recalc_rate(struct clk_hw *hw,
return (unsigned long)fvco;
}

/* todo: implement pl45xx clock round rate operation */
static long samsung_pll45xx_round_rate(struct clk_hw *hw,
unsigned long drate, unsigned long *prate)
{
return -ENOTSUPP;
}

/* todo: implement pl45xx clock set rate */
static int samsung_pll45xx_set_rate(struct clk_hw *hw, unsigned long drate,
unsigned long prate)
{
return -ENOTSUPP;
}

static const struct clk_ops samsung_pll45xx_clk_ops = {
.recalc_rate = samsung_pll45xx_recalc_rate,
.round_rate = samsung_pll45xx_round_rate,
.set_rate = samsung_pll45xx_set_rate,
};

struct clk * __init samsung_clk_register_pll45xx(const char *name,
Expand Down Expand Up @@ -342,24 +294,8 @@ static unsigned long samsung_pll46xx_recalc_rate(struct clk_hw *hw,
return (unsigned long)fvco;
}

/* todo: implement pl46xx clock round rate operation */
static long samsung_pll46xx_round_rate(struct clk_hw *hw,
unsigned long drate, unsigned long *prate)
{
return -ENOTSUPP;
}

/* todo: implement pl46xx clock set rate */
static int samsung_pll46xx_set_rate(struct clk_hw *hw, unsigned long drate,
unsigned long prate)
{
return -ENOTSUPP;
}

static const struct clk_ops samsung_pll46xx_clk_ops = {
.recalc_rate = samsung_pll46xx_recalc_rate,
.round_rate = samsung_pll46xx_round_rate,
.set_rate = samsung_pll46xx_set_rate,
};

struct clk * __init samsung_clk_register_pll46xx(const char *name,
Expand Down Expand Up @@ -441,24 +377,8 @@ static unsigned long samsung_pll2550x_recalc_rate(struct clk_hw *hw,
return (unsigned long)fvco;
}

/* todo: implement pl2550x clock round rate operation */
static long samsung_pll2550x_round_rate(struct clk_hw *hw,
unsigned long drate, unsigned long *prate)
{
return -ENOTSUPP;
}

/* todo: implement pl2550x clock set rate */
static int samsung_pll2550x_set_rate(struct clk_hw *hw, unsigned long drate,
unsigned long prate)
{
return -ENOTSUPP;
}

static const struct clk_ops samsung_pll2550x_clk_ops = {
.recalc_rate = samsung_pll2550x_recalc_rate,
.round_rate = samsung_pll2550x_round_rate,
.set_rate = samsung_pll2550x_set_rate,
};

struct clk * __init samsung_clk_register_pll2550x(const char *name,
Expand Down

0 comments on commit a8b5a39

Please sign in to comment.