Skip to content

Commit

Permalink
target: Remove unused su_group usage in fabric register/dergister
Browse files Browse the repository at this point in the history
This patch removes two instances of left over v3.x code performing local
scope access to struct target_core_fabric_ops->tf_subsys->su_group in
target_fabric_configfs_register() and target_fabric_configfs_deregister().

Reported-by: Christophe Fergeau <cfergeau@gmail.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Nicholas Bellinger committed Jul 22, 2011
1 parent efa4988 commit a8c6da9
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions drivers/target/target_core_configfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,6 @@ static int target_fabric_tf_ops_check(
int target_fabric_configfs_register(
struct target_fabric_configfs *tf)
{
struct config_group *su_group;
int ret;

if (!(tf)) {
Expand All @@ -546,12 +545,6 @@ int target_fabric_configfs_register(
" pointer\n");
return -EINVAL;
}
su_group = &tf->tf_subsys->su_group;
if (!(su_group)) {
printk(KERN_ERR "Unable to locate target struct config_group"
" pointer\n");
return -EINVAL;
}
ret = target_fabric_tf_ops_check(tf);
if (ret < 0)
return ret;
Expand All @@ -565,7 +558,6 @@ EXPORT_SYMBOL(target_fabric_configfs_register);
void target_fabric_configfs_deregister(
struct target_fabric_configfs *tf)
{
struct config_group *su_group;
struct configfs_subsystem *su;

if (!(tf)) {
Expand All @@ -579,13 +571,6 @@ void target_fabric_configfs_deregister(
" pointer\n");
return;
}
su_group = &tf->tf_subsys->su_group;
if (!(su_group)) {
printk(KERN_ERR "Unable to locate target struct config_group"
" pointer\n");
return;
}

printk(KERN_INFO "<<<<<<<<<<<<<<<<<<<<<< BEGIN FABRIC API >>>>>>>>>>"
">>>>>>>>>>>>\n");
mutex_lock(&g_tf_lock);
Expand Down

0 comments on commit a8c6da9

Please sign in to comment.