Skip to content

Commit

Permalink
V4L/DVB: ov7670: Always rewrite clkrc when setting format
Browse files Browse the repository at this point in the history
That makes frame rate configuration persistent.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jonathan Corbet authored and Mauro Carvalho Chehab committed May 18, 2010
1 parent 4671420 commit a8e68c3
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/media/video/ov7670.c
Original file line number Diff line number Diff line change
Expand Up @@ -838,8 +838,12 @@ static int ov7670_s_fmt(struct v4l2_subdev *sd, struct v4l2_format *fmt)
* the other parameters or the image looks poor. If we're *not*
* doing RGB565, we must not rewrite clkrc or the image looks
* *really* poor.
*
* (Update) Now that we retain clkrc state, we should be able
* to write it unconditionally, and that will make the frame
* rate persistent too.
*/
if (fmt->fmt.pix.pixelformat == V4L2_PIX_FMT_RGB565 && ret == 0)
if (ret == 0)
ret = ov7670_write(sd, REG_CLKRC, info->clkrc);
return ret;
}
Expand Down

0 comments on commit a8e68c3

Please sign in to comment.