Skip to content

Commit

Permalink
serial: mfd: snprintf() returns largish values
Browse files Browse the repository at this point in the history
snprintf() returns the number of bytes which would have been written so
it can be larger than the size of the buffer.  In this case it's fine,
but people copy and paste this code so I've fixed it.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Feng Tang <feng.tang@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed Oct 22, 2010
1 parent de838a9 commit a958981
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/serial/mfd.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ static ssize_t port_show_regs(struct file *file, char __user *user_buf,
len += snprintf(buf + len, HSU_REGS_BUFSIZE - len,
"DIV: \t\t0x%08x\n", serial_in(up, UART_DIV));

if (len > HSU_REGS_BUFSIZE)
len = HSU_REGS_BUFSIZE;

ret = simple_read_from_buffer(user_buf, count, ppos, buf, len);
kfree(buf);
return ret;
Expand Down Expand Up @@ -219,6 +222,9 @@ static ssize_t dma_show_regs(struct file *file, char __user *user_buf,
len += snprintf(buf + len, HSU_REGS_BUFSIZE - len,
"D0TSR: \t\t0x%08x\n", chan_readl(chan, HSU_CH_D3TSR));

if (len > HSU_REGS_BUFSIZE)
len = HSU_REGS_BUFSIZE;

ret = simple_read_from_buffer(user_buf, count, ppos, buf, len);
kfree(buf);
return ret;
Expand Down

0 comments on commit a958981

Please sign in to comment.