Skip to content

Commit

Permalink
USB: misc: phidgetmotorcontrol: clean up urb->status usage
Browse files Browse the repository at this point in the history
This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jul 20, 2007
1 parent 2fe8c3f commit a95a038
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions drivers/usb/misc/phidgetmotorcontrol.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,10 @@ static void motorcontrol_irq(struct urb *urb)
struct motorcontrol *mc = urb->context;
unsigned char *buffer = mc->data;
int i, level;
int status;
int retval;
int status = urb->status;;

switch (urb->status) {
switch (status) {
case 0: /* success */
break;
case -ECONNRESET: /* unlink */
Expand Down Expand Up @@ -151,12 +152,12 @@ static void motorcontrol_irq(struct urb *urb)
schedule_delayed_work(&mc->do_notify, 0);

resubmit:
status = usb_submit_urb(urb, GFP_ATOMIC);
if (status)
retval = usb_submit_urb(urb, GFP_ATOMIC);
if (retval)
dev_err(&mc->intf->dev,
"can't resubmit intr, %s-%s/motorcontrol0, status %d",
"can't resubmit intr, %s-%s/motorcontrol0, retval %d",
mc->udev->bus->bus_name,
mc->udev->devpath, status);
mc->udev->devpath, retval);
}

static void do_notify(struct work_struct *work)
Expand Down

0 comments on commit a95a038

Please sign in to comment.