Skip to content

Commit

Permalink
ntp: Make periodic RTC update more reliable
Browse files Browse the repository at this point in the history
The current code requires that the scheduled update of the RTC happens
in the closest tick to the half of the second. This seems to be
difficult to achieve reliably. The scheduled work may be missing the
target time by a tick or two and be constantly rescheduled every second.

Relax the limit to 10 ticks. As a typical RTC drifts in the 11-minute
update interval by several milliseconds, this shouldn't affect the
overall accuracy of the RTC much.

Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
  • Loading branch information
Miroslav Lichvar authored and John Stultz committed Aug 22, 2013
1 parent 397bbf6 commit a97ad0c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion kernel/time/ntp.c
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,7 @@ static void sync_cmos_clock(struct work_struct *work)
* called as close as possible to 500 ms before the new second starts.
* This code is run on a timer. If the clock is set, that timer
* may not expire at the correct time. Thus, we adjust...
* We want the clock to be within a couple of ticks from the target.
*/
if (!ntp_synced()) {
/*
Expand All @@ -485,7 +486,7 @@ static void sync_cmos_clock(struct work_struct *work)
}

getnstimeofday(&now);
if (abs(now.tv_nsec - (NSEC_PER_SEC / 2)) <= tick_nsec / 2) {
if (abs(now.tv_nsec - (NSEC_PER_SEC / 2)) <= tick_nsec * 5) {
struct timespec adjust = now;

fail = -ENODEV;
Expand Down

0 comments on commit a97ad0c

Please sign in to comment.