Skip to content

Commit

Permalink
sh-pfc: Remove check for impossible error condition
Browse files Browse the repository at this point in the history
The pfc pointer can't be NULL in the get and set value functions, remove
the error check.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
  • Loading branch information
Laurent Pinchart authored and Simon Horman committed Jan 25, 2013
1 parent 4a2e0d1 commit a99ebec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/sh/pfc/gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ static void sh_gpio_set_value(struct sh_pfc *pfc, unsigned gpio, int value)
struct pinmux_data_reg *dr = NULL;
int bit = 0;

if (!pfc || sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)
if (sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)
BUG();
else
sh_pfc_write_bit(dr, bit, value);
Expand All @@ -63,7 +63,7 @@ static int sh_gpio_get_value(struct sh_pfc *pfc, unsigned gpio)
struct pinmux_data_reg *dr = NULL;
int bit = 0;

if (!pfc || sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)
if (sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)
return -EINVAL;

return sh_pfc_read_bit(dr, bit);
Expand Down

0 comments on commit a99ebec

Please sign in to comment.