Skip to content

Commit

Permalink
drm: make drm_get_minor() static
Browse files Browse the repository at this point in the history
drm_get_minor() is only used in one file. Make it static and add a
kernel-doc comment which documents the current semantics.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
David Herrmann authored and Dave Airlie committed Nov 6, 2013
1 parent 4ac387f commit a99ee45
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
19 changes: 11 additions & 8 deletions drivers/gpu/drm/drm_stub.c
Original file line number Diff line number Diff line change
Expand Up @@ -255,16 +255,20 @@ int drm_dropmaster_ioctl(struct drm_device *dev, void *data,
}

/**
* Get a secondary minor number.
* drm_get_minor - Allocate and register new DRM minor
* @dev: DRM device
* @minor: Pointer to where new minor is stored
* @type: Type of minor
*
* \param dev device data structure
* \param sec-minor structure to hold the assigned minor
* \return negative number on failure.
* Allocate a new minor of the given type and register it. A pointer to the new
* minor is returned in @minor.
* Caller must hold the global DRM mutex.
*
* Search an empty entry and initialize it to the given parameters. This
* routines assigns minor numbers to secondary heads of multi-headed cards
* RETURNS:
* 0 on success, negative error code on failure.
*/
int drm_get_minor(struct drm_device *dev, struct drm_minor **minor, int type)
static int drm_get_minor(struct drm_device *dev, struct drm_minor **minor,
int type)
{
struct drm_minor *new_minor;
int ret;
Expand Down Expand Up @@ -321,7 +325,6 @@ int drm_get_minor(struct drm_device *dev, struct drm_minor **minor, int type)
*minor = NULL;
return ret;
}
EXPORT_SYMBOL(drm_get_minor);

/**
* drm_unplug_minor - Unplug DRM minor
Expand Down
1 change: 0 additions & 1 deletion include/drm/drmP.h
Original file line number Diff line number Diff line change
Expand Up @@ -1630,7 +1630,6 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver,
void drm_dev_free(struct drm_device *dev);
int drm_dev_register(struct drm_device *dev, unsigned long flags);
void drm_dev_unregister(struct drm_device *dev);
int drm_get_minor(struct drm_device *dev, struct drm_minor **minor, int type);
/*@}*/

/* PCI section */
Expand Down

0 comments on commit a99ee45

Please sign in to comment.