Skip to content

Commit

Permalink
PCI: fix rpadlpar pci hotplug driver sysfs usage
Browse files Browse the repository at this point in the history
When Greg "fixed" the sysfs usage of that driver a while back, he seem
to have introduced a bug where the quotes are added around the name of
our specific sysfs files, thus breaking the user space tool.

This fixes it. Tested DLPAR operations on a POWER6 machine successfully.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Benjamin Herrenschmidt authored and Jesse Barnes committed May 30, 2008
1 parent 0a2ce2f commit a9b841e
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/pci/hotplug/rpadlpar_sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,12 @@
#include "rpadlpar.h"

#define DLPAR_KOBJ_NAME "control"
#define ADD_SLOT_ATTR_NAME "add_slot"
#define REMOVE_SLOT_ATTR_NAME "remove_slot"

/* Those two have no quotes because they are passed to __ATTR() which
* stringifies the argument (yuck !)
*/
#define ADD_SLOT_ATTR_NAME add_slot
#define REMOVE_SLOT_ATTR_NAME remove_slot

#define MAX_DRC_NAME_LEN 64

Expand Down

0 comments on commit a9b841e

Please sign in to comment.