Skip to content

Commit

Permalink
tracing: Add proper check for irq_depth routines
Browse files Browse the repository at this point in the history
The check_irq_entry and check_irq_return could be called
from graph event context. In such case there's no graph
private data allocated. Adding checks to handle this case.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
LKML-Reference: <20100924154102.GB1818@jolsa.brq.redhat.com>

[ Fixed some grammar in the comments ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Jiri Olsa authored and Steven Rostedt committed Oct 18, 2010
1 parent 907f278 commit a9d6117
Showing 1 changed file with 20 additions and 4 deletions.
24 changes: 20 additions & 4 deletions kernel/trace/trace_functions_graph.c
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,20 @@ check_irq_entry(struct trace_iterator *iter, u32 flags,
unsigned long addr, int depth)
{
int cpu = iter->cpu;
int *depth_irq;
struct fgraph_data *data = iter->private;
int *depth_irq = &(per_cpu_ptr(data->cpu_data, cpu)->depth_irq);

if (flags & TRACE_GRAPH_PRINT_IRQS)
/*
* If we are either displaying irqs, or we got called as
* a graph event and private data does not exist,
* then we bypass the irq check.
*/
if ((flags & TRACE_GRAPH_PRINT_IRQS) ||
(!data))
return 0;

depth_irq = &(per_cpu_ptr(data->cpu_data, cpu)->depth_irq);

/*
* We are inside the irq code
*/
Expand Down Expand Up @@ -926,12 +934,20 @@ static int
check_irq_return(struct trace_iterator *iter, u32 flags, int depth)
{
int cpu = iter->cpu;
int *depth_irq;
struct fgraph_data *data = iter->private;
int *depth_irq = &(per_cpu_ptr(data->cpu_data, cpu)->depth_irq);

if (flags & TRACE_GRAPH_PRINT_IRQS)
/*
* If we are either displaying irqs, or we got called as
* a graph event and private data does not exist,
* then we bypass the irq check.
*/
if ((flags & TRACE_GRAPH_PRINT_IRQS) ||
(!data))
return 0;

depth_irq = &(per_cpu_ptr(data->cpu_data, cpu)->depth_irq);

/*
* We are not inside the irq code.
*/
Expand Down

0 comments on commit a9d6117

Please sign in to comment.