Skip to content

Commit

Permalink
HID: logitech-dj: Allow incoming packets during probe().
Browse files Browse the repository at this point in the history
Historically, logitech-dj communicated with the device during probe()
to query the list of devices attached. Later, a change was introduced
to hid-core that prevented incoming packets for a device during
probe(), as many drivers are unable to handle such input. That change
broke the device enumeration in logitech-dj, so commit
5962640 was introduced to workaround that by waiting for
normal input before enumerating devices.

Now that drivers can opt-in to receive input during probe, this patch
changes logitech-dj to do that, so that it can successfully complete
enumeration of devices during probe().

Signed-off-by: Andrew de los Reyes <adlr@chromium.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Andrew de los Reyes authored and Jiri Kosina committed Mar 1, 2013
1 parent c849a61 commit a9dd22b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/hid/hid-logitech-dj.c
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,9 @@ static int logi_dj_probe(struct hid_device *hdev,
goto llopen_failed;
}

/* Allow incoming packets to arrive: */
hid_device_io_start(hdev);

retval = logi_dj_recv_query_paired_devices(djrcv_dev);
if (retval < 0) {
dev_err(&hdev->dev, "%s:logi_dj_recv_query_paired_devices "
Expand Down

0 comments on commit a9dd22b

Please sign in to comment.