Skip to content

Commit

Permalink
lustre: delete linux/lustre_debug.h
Browse files Browse the repository at this point in the history
There was only one macro in here, LL_CDEBUG_PAGE().  So open code it in
the 2 places it was used so that the developer seeing it can see just
how horrid it really is, and they can remove it as I doubt it really is
ever needed anymore.  But for now, keep the same functionality and
remove a whole file (with a duplicate name of other files in the lustre
repo, another confusion...)

Cc: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Jan 14, 2014
1 parent 187df69 commit aa3bee0
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 53 deletions.
47 changes: 0 additions & 47 deletions drivers/staging/lustre/lustre/include/linux/lustre_debug.h

This file was deleted.

2 changes: 0 additions & 2 deletions drivers/staging/lustre/lustre/include/lustre_debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@
#include <lustre_net.h>
#include <obd.h>

#include <linux/lustre_debug.h>

/* lib/debug.c */
void dump_lniobuf(struct niobuf_local *lnb);
int dump_req(struct ptlrpc_request *req);
Expand Down
7 changes: 5 additions & 2 deletions drivers/staging/lustre/lustre/llite/vvp_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -628,8 +628,11 @@ static int vvp_io_kernel_fault(struct vvp_fault_io *cfio)
cfio->fault.ft_flags = filemap_fault(cfio->ft_vma, vmf);

if (vmf->page) {
LL_CDEBUG_PAGE(D_PAGE, vmf->page, "got addr %p type NOPAGE\n",
vmf->virtual_address);
CDEBUG(D_PAGE,
"page %p map %p index %lu flags %lx count %u priv %0lx: got addr %p type NOPAGE\n",
vmf->page, vmf->page->mapping, vmf->page->index,
(long)vmf->page->flags, page_count(vmf->page),
page_private(vmf->page), vmf->virtual_address);
if (unlikely(!(cfio->fault.ft_flags & VM_FAULT_LOCKED))) {
lock_page(vmf->page);
cfio->fault.ft_flags &= VM_FAULT_LOCKED;
Expand Down
8 changes: 6 additions & 2 deletions drivers/staging/lustre/lustre/osc/osc_request.c
Original file line number Diff line number Diff line change
Expand Up @@ -1193,8 +1193,12 @@ static obd_count osc_checksum_bulk(int nob, obd_count pg_count,
cfs_crypto_hash_update_page(hdesc, pga[i]->pg,
pga[i]->off & ~CFS_PAGE_MASK,
count);
LL_CDEBUG_PAGE(D_PAGE, pga[i]->pg, "off %d\n",
(int)(pga[i]->off & ~CFS_PAGE_MASK));
CDEBUG(D_PAGE,
"page %p map %p index %lu flags %lx count %u priv %0lx: off %d\n",
pga[i]->pg, pga[i]->pg->mapping, pga[i]->pg->index,
(long)pga[i]->pg->flags, page_count(pga[i]->pg),
page_private(pga[i]->pg),
(int)(pga[i]->off & ~CFS_PAGE_MASK));

nob -= pga[i]->count;
pg_count--;
Expand Down

0 comments on commit aa3bee0

Please sign in to comment.