Skip to content

Commit

Permalink
squashfs: xattr_lookup sparse fix
Browse files Browse the repository at this point in the history
Sparse detected that unsigned pointer was being passed as int pointer.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
[fixed up to deal with code refactoring]
Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk>
  • Loading branch information
Stephen Hemminger authored and Phillip Lougher committed May 17, 2010
1 parent 01e5b4e commit aa5b189
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions fs/squashfs/xattr.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
extern __le64 *squashfs_read_xattr_id_table(struct super_block *, u64,
u64 *, int *);
extern int squashfs_xattr_lookup(struct super_block *, unsigned int, int *,
int *, long long *);
int *, unsigned long long *);
#else
static inline __le64 *squashfs_read_xattr_id_table(struct super_block *sb,
u64 start, u64 *xattr_table_start, int *xattr_ids)
Expand All @@ -35,7 +35,8 @@ static inline __le64 *squashfs_read_xattr_id_table(struct super_block *sb,
}

static inline int squashfs_xattr_lookup(struct super_block *sb,
unsigned int index, int *count, int *size, long long *xattr)
unsigned int index, int *count, int *size,
unsigned long long *xattr)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion fs/squashfs/xattr_id.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
* Map xattr id using the xattr id look up table
*/
int squashfs_xattr_lookup(struct super_block *sb, unsigned int index,
int *count, int *size, long long *xattr)
int *count, unsigned int *size, unsigned long long *xattr)
{
struct squashfs_sb_info *msblk = sb->s_fs_info;
int block = SQUASHFS_XATTR_BLOCK(index);
Expand Down

0 comments on commit aa5b189

Please sign in to comment.