Skip to content

Commit

Permalink
ftrace: remove packed attribute on ftrace_page.
Browse files Browse the repository at this point in the history
It causes unaligned access traps on platforms like sparc
(ftrace_page may be marked packed, but once we return
a dyn_ftrace sub-object from this array to another piece
of code, the "packed" part of the typing information doesn't
propagate).

But also, it didn't serve any purpose either.  Even if packed,
on 64-bit or 32-bit, it didn't give us any more dyn_ftrace
entries per-page.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
David Miller authored and Thomas Gleixner committed May 23, 2008
1 parent 74f4e36 commit aa5e5ce
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/trace/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ static DEFINE_MUTEX(ftrace_filter_lock);

struct ftrace_page {
struct ftrace_page *next;
int index;
unsigned long index;
struct dyn_ftrace records[];
} __attribute__((packed));
};

#define ENTRIES_PER_PAGE \
((PAGE_SIZE - sizeof(struct ftrace_page)) / sizeof(struct dyn_ftrace))
Expand Down

0 comments on commit aa5e5ce

Please sign in to comment.