Skip to content

Commit

Permalink
Define and use PCI_DEVICE_ID_MARVELL_88ALP01_CCIC for CAFÉ camera driver
Browse files Browse the repository at this point in the history
Also, stop looking at the NAND controller (0x4100) and checking the
device class. For a while during development, all three functions on the
chip had the same ID. We made them fix that fairly promptly, and we can
forget about it now.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
  • Loading branch information
David Woodhouse authored and David Woodhouse committed Sep 4, 2008
1 parent 514fca4 commit aa7a7fb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
13 changes: 3 additions & 10 deletions drivers/media/video/cafe_ccic.c
Original file line number Diff line number Diff line change
Expand Up @@ -2091,15 +2091,8 @@ static int cafe_pci_probe(struct pci_dev *pdev,
const struct pci_device_id *id)
{
int ret;
u16 classword;
struct cafe_camera *cam;
/*
* Make sure we have a camera here - we'll get calls for
* the other cafe devices as well.
*/
pci_read_config_word(pdev, PCI_CLASS_DEVICE, &classword);
if (classword != PCI_CLASS_MULTIMEDIA_VIDEO)
return -ENODEV;

/*
* Start putting together one of our big camera structures.
*/
Expand Down Expand Up @@ -2287,8 +2280,8 @@ static int cafe_pci_resume(struct pci_dev *pdev)


static struct pci_device_id cafe_ids[] = {
{ PCI_DEVICE(0x11ab, 0x4100) }, /* Eventual real ID */
{ PCI_DEVICE(0x11ab, 0x4102) }, /* Really eventual real ID */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL,
PCI_DEVICE_ID_MARVELL_88ALP01_CCIC) },
{ 0, }
};

Expand Down
1 change: 1 addition & 0 deletions include/linux/pci_ids.h
Original file line number Diff line number Diff line change
Expand Up @@ -1523,6 +1523,7 @@
#define PCI_DEVICE_ID_MARVELL_MV64460 0x6480
#define PCI_DEVICE_ID_MARVELL_88ALP01_NAND 0x4100
#define PCI_DEVICE_ID_MARVELL_88ALP01_SD 0x4101
#define PCI_DEVICE_ID_MARVELL_88ALP01_CCIC 0x4102

#define PCI_VENDOR_ID_V3 0x11b0
#define PCI_DEVICE_ID_V3_V960 0x0001
Expand Down

0 comments on commit aa7a7fb

Please sign in to comment.